apeforest commented on a change in pull request #14403: Fix slice op issues
#13760 and #14105
URL: https://github.com/apache/incubator-mxnet/pull/14403#discussion_r265821070
##########
File path: src/operator/tensor/matrix_op-inl.h
##########
@@ -675,20 +675,31 @@ inline void GetIndexRange(const mxnet::TShape& dshape,
b = len - 1;
}
CHECK_LT(b, len) << "slicing with begin[" << i << "]="
- << b << " exceends limit of " << len;
+ << b << " exceeds limit of " << len;
Review comment:
Yes, I think providing a clear error message will improve user experience
significantly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
