nswamy commented on a change in pull request #14346: [MXNet-1334][Fit API]base class for estimator and eventhandler URL: https://github.com/apache/incubator-mxnet/pull/14346#discussion_r266189295
########## File path: python/mxnet/gluon/estimator/estimator.py ########## @@ -0,0 +1,267 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# coding: utf-8 +# pylint: disable=wildcard-import +"""Gluon Estimator""" + +import warnings + +from .event_handler import LoggingHandler +from ... import gluon, autograd +from ...context import Context, cpu, gpu, num_gpus +from ...io import DataIter +from ...metric import EvalMetric, Loss + +__all__ = ['Estimator'] + + +class Estimator(object): + """Estimator Class for easy model training + + :py:class:`Estimator` can be used to facilitate the training & validation process + + + Parameters + ---------- + loss : Loss or list of Loss + Loss(objective functions) to calculate during training + metrics : EvalMetric or list of EvalMetric + Metrics for evaluating models + initializer : Initializer + initializer to initialize the network + trainers : Trainer or list of Trainer + Trainers to apply optimizers on network parameters + context : Context or list of Context + devices to run the training on + """ + + def __init__(self, net, + loss=None, + metrics=None, + initializer=None, + trainers=None, + context=None): + + self.net = net + self.stop_training = False + + if isinstance(loss, gluon.loss.Loss): + self.loss = [loss] + else: + self.loss = loss or [] + for l in self.loss: + if not isinstance(loss, gluon.loss.Loss): + raise ValueError("loss must be a Loss or a list of Loss, refer to gluon.loss.Loss") + + if isinstance(metrics, EvalMetric): + self.metrics = [metrics] + else: + self.metrics = metrics or [] Review comment: do we allow anything but EvalMetric, if not please validate each metric in the list is a EvalMetric. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
