eric-haibin-lin commented on a change in pull request #14487: [numpy] Fix unit
tests after introducing numpy compatible shapes
URL: https://github.com/apache/incubator-mxnet/pull/14487#discussion_r268443331
##########
File path: src/c_api/c_api_common.h
##########
@@ -91,7 +91,7 @@ struct MXAPIThreadLocalEntry {
data->resize(shapes.size());
size_t size = 0;
for (const auto& s : shapes) {
- CHECK_GE(s.ndim(), 0);
+ if (s.ndim() > 0);
Review comment:
why not remove this line of code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
