gavinmbell commented on issue #14504: Fixes for CI downloads URL: https://github.com/apache/incubator-mxnet/pull/14504#issuecomment-476397435 There are two download() functions here. Can we put that download function in a library type of script and then use it accordingly - to adhere to a DRY (Don't Repeat Yourself) sensibility? The diff seems to be with unzipping activities. I realize one is in 'examples' (cpp-package/example/get_data.sh) and the other under tools (tools/dependencies/make_shared_dependencies.sh) - perhaps these are disparate enough things to warrant a copy and paste - I don't know. Just flagging this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
