ZhennanQin commented on a change in pull request #14528: Performance improving for MKL-DNN Quantized FullyConnected URL: https://github.com/apache/incubator-mxnet/pull/14528#discussion_r269378156
########## File path: src/operator/quantization/mkldnn/mkldnn_quantized_fully_connected.cc ########## @@ -52,15 +47,15 @@ void MKLDNNQuantizedFullyConnectedForward(const nnvm::NodeAttrs &attrs, NDArray weight = in_data[fullc::kWeight]; const float min_data = - in_data[num_inputs + quantized_fc_enum::kDataMin].data().dptr<float>()[0]; + in_data[num_inputs + quantized_fullc::kDataMin].data().dptr<float>()[0]; Review comment: Quite strange usage. Why not define a whole input sets with original inputs? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
