TaoLv commented on a change in pull request #14534: [DOC] Update ubuntu install
instructions from source
URL: https://github.com/apache/incubator-mxnet/pull/14534#discussion_r269616128
##########
File path: docs/install/ubuntu_setup.md
##########
@@ -170,44 +191,72 @@ If building on CPU and using OpenBLAS:
```bash
git clone --recursive https://github.com/apache/incubator-mxnet.git
cd incubator-mxnet
- echo "USE_OPENCV = 1" >> ./config.mk
- echo "USE_BLAS = openblas" >> ./config.mk
- make -j $(nproc)
+```
+
+
+```bash
+ rm -rf build
+ mkdir -p build && cd build
+ cmake -GNinja \
+ -DUSE_CUDA=OFF \
+ -DUSE_MKL_IF_AVAILABLE=OFF \
+ -DCMAKE_CUDA_COMPILER_LAUNCHER=ccache \
+ -DCMAKE_C_COMPILER_LAUNCHER=ccache \
+ -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
+ ..
+ ninja
Review comment:
`-DUSE_MKLDNN` will be turned on by default in this cmake line? Seems we
need change the description in the next section and document the default
behavior somewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services