reminisce commented on a change in pull request #14113: Enhance subgraph API
URL: https://github.com/apache/incubator-mxnet/pull/14113#discussion_r269838335
##########
File path: src/operator/subgraph/build_subgraph.cc
##########
@@ -180,41 +150,40 @@ bool LabelSubgraph(const Graph& g,
std::pair<std::vector<const nnvm::Node*>,
std::vector<const nnvm::Node*>>> non_subgraph_node_map;
while (!node_queue.empty()) {
- SimpleNode* cur_node = node_queue.front();
+ auto cur_node = node_queue.front();
Review comment:
nit: Be expressive by avoiding using `auto`. `auto` is not good for
readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
