reminisce commented on a change in pull request #14612: [Numpy] Misc fix
URL: https://github.com/apache/incubator-mxnet/pull/14612#discussion_r271953042
##########
File path: src/ndarray/ndarray.cc
##########
@@ -1663,7 +1663,7 @@ bool NDArray::LegacyLoad(dmlc::Stream *strm, const
uint32_t magic) {
// load shape
mxnet::TShape shape;
if (!LegacyTShapeLoad(strm, &shape, magic)) return false;
- if (shape.ndim() == 0) {
+ if (mxnet::op::shape_is_none(shape)) {
Review comment:
This should be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services