larroy commented on a change in pull request #14613: [MXNET-978] Higher order
gradient support for some unary operators
URL: https://github.com/apache/incubator-mxnet/pull/14613#discussion_r271983113
##########
File path: src/imperative/imperative.cc
##########
@@ -347,8 +347,9 @@ std::vector<NDArray*> Imperative::Backward(
x_reqs.push_back(info.grad_req);
info.fresh_out_grad = true;
}
- CHECK_GT(xs.size(), 0)
- << "There are no inputs in computation graph that require gradients.";
+ if (xs.empty()) {
Review comment:
Why change from CHECK to warning?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
