roywei edited a comment on issue #14629: [MXNET-1333] Estimator and Fit API URL: https://github.com/apache/incubator-mxnet/pull/14629#issuecomment-480438825 Thanks @szha for the feedback! I m noting the summary of offlien discussion here: 1. Currently event handlers has access to entire estimator. Estimator has to maintain different stats/states (e.g. current epoch, num of steps, metrics) and do the book keeping to ensure eventhandlers has them when they are called. 2. If user want to add an event handler that want to use some info estimator does not have. He has to add it in estimator and change the estimator code to do book keeping. He has to know he can access current epoch from estimator.currrent_epoch, not some other variable name. 3. Separate event handlers into 6 classes (train begin class, train end class ect) instead of single eventhandler parent class. Each class maintain it's own info/state and know what args to pass when called. So estimator does not do the state management. 4. Using the gluon forward hook approch to provide avaibilty to detach a event handler. (e.g. remove some handler after n epochs/steps)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
