sxjscience commented on a change in pull request #14476: Change RNN OP to
stateful
URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r272830102
##########
File path: src/operator/rnn-inl.h
##########
@@ -436,387 +563,901 @@ class RNNOp : public Operator{
if (param_.state_outputs) {
hy_ptr = out_data[rnn_enum::kStateOut].dptr<DType>();
}
- DType* cx_ptr = NULL;
- DType* cy_ptr = NULL;
+ DType * cx_ptr = NULL;
+ DType * cy_ptr = NULL;
Review comment:
`DType* cx_ptr` looks better and makes the style more consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
