eric-haibin-lin commented on a change in pull request #14606: Add nd.power and
sym.pow
URL: https://github.com/apache/incubator-mxnet/pull/14606#discussion_r272844847
##########
File path: python/mxnet/ndarray/ndarray.py
##########
@@ -46,7 +46,7 @@
"ones", "add", "arange", "eye", "divide", "equal", "full",
"greater", "greater_equal",
"imdecode", "lesser", "lesser_equal", "logical_and", "logical_or",
"logical_xor",
"maximum", "minimum", "moveaxis", "modulo", "multiply",
"not_equal", "onehot_encode",
- "power", "subtract", "true_divide", "waitall", "_new_empty_handle",
"histogram",
+ "pow", "power", "subtract", "true_divide", "waitall",
"_new_empty_handle", "histogram",
Review comment:
I do not think it's a good practice to intentionally introduce multiple APIs
that do the same thing. Since there is `numpy.power`, I'd rather add
`symbol.power`, document `symbol.pow` is deprecated and will be replaced by
sym.power.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
