wkcn commented on a change in pull request #10792: [MXNET-400] support string type for kvstore key in cpp-package URL: https://github.com/apache/incubator-mxnet/pull/10792#discussion_r272915310
########## File path: cpp-package/example/test_kvstore.cpp ########## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#include "mxnet/c_api.h" // MXGetGPUCount() +#include "mxnet-cpp/MxNetCpp.h" + +using namespace mxnet::cpp; + +static bool test_single_key(const Context &context, const std::string &context_str) { + std::string key = "singlekeytest-" + context_str; + + NDArray result(Shape(4), context); + NDArray result_cpu; + + // initialize data + NDArray data_cpu({0.f, 233.f, -0.12f, 9.f}, Shape(4), Context::cpu()); + NDArray data = data_cpu.Copy(context); + NDArray::WaitAll(); + + KVStore::Init(key, data); + NDArray::WaitAll(); + + // retrieve result + KVStore::Pull(key, &result); + NDArray::WaitAll(); + + result_cpu = result.Copy(Context::cpu()); + NDArray::WaitAll(); + + // compare + for (size_t j=0; j < result_cpu.Size(); j++) { + if (result_cpu.GetData()[j] != data_cpu.GetData()[j]) { + LG << "Error: wrong initialized data in singlekeytest-" << context_str + << ", expect " << data_cpu.GetData()[j] + << " got " << result_cpu.GetData()[j]; + return false; + } + } + + // push gradient + NDArray grad_cpu({0.1f, -2.f, -4.4f, 0.f}, Shape(4), Context::cpu()); + NDArray grad = grad_cpu.Copy(context); + NDArray::WaitAll(); + + KVStore::Push(key, grad); + NDArray::WaitAll(); + + // retrieve result + KVStore::Pull(key, &result); + NDArray::WaitAll(); + + result_cpu = result.Copy(Context::cpu()); + NDArray::WaitAll(); + + // compare + for (size_t j=0; j < result_cpu.Size(); j++) { + if (result_cpu.GetData()[j] != grad_cpu.GetData()[j]) { + LG << "Error: wrong gradient data in singlekeytest-" << context_str + << ", expect " << grad_cpu.GetData()[j] + << " got " << result_cpu.GetData()[j]; + return false; + } + } + + return true; +} + +static bool test_multiple_key(const Context &context, const std::string &context_str) { + std::vector<std::string> keys(2); + keys[0] = "multikeytest-0-" + context_str; + keys[1] = "multikeytest-1-" + context_str; + + std::vector<NDArray> results(2); + results[0] = NDArray(Shape(4), context); + results[1] = NDArray(Shape(4), context); + std::vector<NDArray> results_cpu(2); + + // initialize data + std::vector<NDArray> data_cpu(2); + data_cpu[0] = NDArray({0.f, 2.f, -3.12f, 4.f}, Shape(4), Context::cpu()); + data_cpu[1] = NDArray({0.8f, -2.f, 6.6f, 77.f}, Shape(4), Context::cpu()); + std::vector<NDArray> data(2); + data[0] = data_cpu[0].Copy(context); + data[1] = data_cpu[1].Copy(context); + NDArray::WaitAll(); + + KVStore::Init(keys, data); + NDArray::WaitAll(); + + // retrieve result + KVStore::Pull(keys, &results); + NDArray::WaitAll(); + + results_cpu[0] = results[0].Copy(Context::cpu()); + results_cpu[1] = results[1].Copy(Context::cpu()); + NDArray::WaitAll(); + + // compare + for (size_t i=0; i < results_cpu.size(); i++) { + for (size_t j=0; j < results_cpu[i].Size(); j++) { + if (results_cpu[i].GetData()[j] != data_cpu[i].GetData()[j]) { + LG << "Error: wrong initialized data in multikeytest-" << context_str + << ", expect " << data_cpu[i].GetData()[j] + << " got " << results_cpu[i].GetData()[j]; + return false; + } + } + } + + // push gradient, reduce for the second + std::vector<std::string> push_keys(3); + push_keys[0] = "multikeytest-0-" + context_str; + push_keys[1] = "multikeytest-1-" + context_str; + push_keys[2] = "multikeytest-1-" + context_str; Review comment: I see. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
