zachgk commented on a change in pull request #14645: [MXNET-1383] Java new use
of ParamObject
URL: https://github.com/apache/incubator-mxnet/pull/14645#discussion_r273274760
##########
File path:
scala-package/macros/src/main/scala/org/apache/mxnet/APIDocGenerator.scala
##########
@@ -129,15 +130,16 @@ private[mxnet] object APIDocGenerator extends
GeneratorBase with RandomHelpers {
}
}).map(absClassFunction => {
generateJavaAPISignature(absClassFunction)
- }).toSeq
+ }).toSeq.unzip
+ val paramClass = paramClassUncleaned.filter(!_.isEmpty)
Review comment:
I just noticed there is a .filterNot method since it is used on line 119
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services