eric-haibin-lin commented on a change in pull request #14627: Speed up
SequenceReverse
URL: https://github.com/apache/incubator-mxnet/pull/14627#discussion_r273293692
##########
File path: src/operator/sequence_reverse-inl.h
##########
@@ -118,9 +115,25 @@ class SequenceReverseOp : public Operator {
const index_t other_dim = data.size(2);
const index_t tensor_numel = data.shape_.Size();
- mxnet_op::Kernel<ReverseKernel, xpu>::Launch(
- s, max_seq_len, out.dptr_, data.dptr_, req, max_seq_len, batch_size,
- other_dim, tensor_numel, indices);
+ switch (req) {
Review comment:
Oh there is `MXNET_ASSIGN_REQ_SWITCH`.. but this is fine, too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services