lebeg commented on a change in pull request #14530: Added repeats for github
status updates
URL: https://github.com/apache/incubator-mxnet/pull/14530#discussion_r273485161
##########
File path: ci/Jenkinsfile_utils.groovy
##########
@@ -186,18 +186,27 @@ def update_github_commit_status(state, message) {
context = get_github_context()
echo "context=${context}"
- step([
- $class: 'GitHubCommitStatusSetter',
- reposSource: [$class: "ManuallyEnteredRepositorySource", url: repoUrl],
- contextSource: [$class: "ManuallyEnteredCommitContextSource", context:
context],
- commitShaSource: [$class: "ManuallyEnteredShaSource", sha: commitSha],
- statusBackrefSource: [$class: "ManuallyEnteredBackrefSource", backref:
"${env.RUN_DISPLAY_URL}"],
- errorHandlers: [[$class: 'ShallowAnyErrorHandler']],
- statusResultSource: [
- $class: 'ConditionalStatusResultSource',
- results: [[$class: "AnyBuildResult", message: message, state: state]]
- ]
- ])
+ // a few attempts need to be made:
https://github.com/apache/incubator-mxnet/issues/11654
+ for (int attempt = 1; attempt <= 3; attempt++) {
Review comment:
Maybe I'll mention again here the reasons mentioned in the description of
this PR for clarity:
> * Using a different Jenkins plugin GitHub Integration Plugin has been
considered, but unfortunately after installation there was not way to configure
it - the options were missing from the configuration screen
> * All other plugins required explicit credentials passing as arguments
> * No way of asking for the commit status for verification has been found
to check the status after the update
> * No way for checking the list of repositories that need to be updated was
found (and whether it's empty) - all what happens, happens internally in the
plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
