zachgk commented on a change in pull request #14656: [MXNET-1385] Improved
Scala Init and Macros warning messages
URL: https://github.com/apache/incubator-mxnet/pull/14656#discussion_r274157948
##########
File path:
scala-package/macros/src/main/scala/org/apache/mxnet/GeneratorBase.scala
##########
@@ -17,16 +17,20 @@
package org.apache.mxnet
-import org.apache.mxnet.init.Base.{RefInt, RefLong, RefString, _LIB}
-import org.apache.mxnet.utils.{CToScalaUtils, OperatorBuildUtils}
+import org.apache.mxnet.init.Base.{CPtrAddress, RefInt, RefLong, RefString,
_LIB}
+import org.apache.mxnet.utils.CToScalaUtils
import scala.collection.mutable.ListBuffer
import scala.reflect.macros.blackbox
private[mxnet] abstract class GeneratorBase {
- type Handle = Long
case class Arg(argName: String, argType: String, argDesc: String,
isOptional: Boolean) {
+ /**
+ * filter the arg name with the Scala keyword
Review comment:
Can you add a bit more description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
