glingyan commented on a change in pull request #14492: use mkl sparse matrix to improve performance URL: https://github.com/apache/incubator-mxnet/pull/14492#discussion_r274714539
########## File path: 3rdparty/sparse-matrix/sparse_matrix.cc ########## @@ -0,0 +1,45 @@ +#include <iostream> +#include <string> +#include <fstream> +#include <mkl_spblas.h> +#include "sparse_matrix.h" + + + +bool mkl_DotCsrDnsDns(SP_INT64* rows_start, SP_INT64* col_indx, Review comment: mshadw use 32bit interface , below is the link for mkl settings https://software.intel.com/en-us/articles/intel-mkl-link-line-advisor and the make should change diff --git a/make/mshadow.mk b/make/mshadow.mk index 86155ea..d0b731e 100644 --- a/make/mshadow.mk +++ b/make/mshadow.mk @@ -82,7 +82,7 @@ ifneq ($(USE_INTEL_PATH), NONE) MSHADOW_LDFLAGS += -L$(USE_INTEL_PATH)/compiler/lib/intel64 MSHADOW_LDFLAGS += -L$(USE_INTEL_PATH)/lib/intel64 endif - MSHADOW_CFLAGS += -I$(USE_INTEL_PATH)/mkl/include + MSHADOW_CFLAGS += -I$(USE_INTEL_PATH)/mkl/include -DMKL_ILP64 -m64 endif ifneq ($(USE_STATIC_MKL), NONE) ifeq ($(USE_INTEL_PATH), NONE) @@ -90,7 +90,7 @@ ifeq ($(USE_INTEL_PATH), NONE) else MKLROOT = $(USE_INTEL_PATH)/mkl endif - MSHADOW_LDFLAGS += -L${MKLROOT}/../compiler/lib/intel64 -Wl,--start-group ${MKLROOT}/lib/intel64/libmkl_intel_lp64.a ${MKLROOT}/lib/intel64/libmkl_core.a ${MKLROOT}/lib/intel64/libmkl_intel_thread.a -Wl,--end-group -liomp5 -ldl -lpthread -lm + MSHADOW_LDFLAGS += -L${MKLROOT}/../compiler/lib/intel64 -Wl,--start-group ${MKLROOT}/lib/intel64/libmkl_intel_ilp64.a ${MKLROOT}/lib/intel64/libmkl_core.a ${MKLROOT}/lib/intel64/libmkl_intel_thread.a -Wl,--end-group -liomp5 -ldl -lpthread -lm else ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
