sl1pkn07 commented on issue #13578: [CMake] Make install / ninja install 
failing [dmlc-core]
URL: 
https://github.com/apache/incubator-mxnet/issues/13578#issuecomment-482718523
 
 
   ~~~
   diff --git a/CMakeLists.txt b/CMakeLists.txt
   index e121549b19..fa9017421d 100644
   --- a/CMakeLists.txt
   +++ b/CMakeLists.txt
   @@ -759,10 +759,10 @@ install(TARGETS ${MXNET_INSTALL_TARGETS}
    #       https://cmake.org/cmake/help/v3.0/variable/CMAKE_INSTALL_PREFIX.html
    #       https://cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html
    
   -install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
   -install(DIRECTORY 3rdparty/tvm/nnvm/include/ DESTINATION 
${CMAKE_INSTALL_INCLUDEDIR})
   +install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/include/ DESTINATION 
${CMAKE_INSTALL_INCLUDEDIR})
   +install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/tvm/nnvm/include/ 
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
    if (INSTALL_EXAMPLES)
   -  install(DIRECTORY example  DESTINATION 
${CMAKE_INSTALL_DATADIR}/${PROJECT_NAME})
   +  install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/example  DESTINATION 
${CMAKE_INSTALL_DATADIR}/${PROJECT_NAME})
    endif()
    
    if (USE_SIGNAL_HANDLER)
   diff --git a/cpp-package/CMakeLists.txt b/cpp-package/CMakeLists.txt
   index fec86e78e6..fea58ed91a 100644
   --- a/cpp-package/CMakeLists.txt
   +++ b/cpp-package/CMakeLists.txt
   @@ -20,6 +20,6 @@ if(USE_CPP_PACKAGE)
        add_subdirectory(example)
      endif()
    
   -  install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
   +  install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/include/ DESTINATION 
${CMAKE_INSTALL_INCLUDEDIR})
    
    endif()
    if (INSTALL_EXAMPLES)
   -  install(DIRECTORY example  DESTINATION 
${CMAKE_INSTALL_DATADIR}/${PROJECT_NAME})
   +  install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/example  DESTINATION 
${CMAKE_INSTALL_DATADIR}/${PROJECT_NAME})
    endif()
    
    if (USE_SIGNAL_HANDLER)
   diff --git a/cpp-package/CMakeLists.txt b/cpp-package/CMakeLists.txt
   index fec86e78e6..fea58ed91a 100644
   --- a/cpp-package/CMakeLists.txt
   +++ b/cpp-package/CMakeLists.txt
   @@ -20,6 +20,6 @@ if(USE_CPP_PACKAGE)
        add_subdirectory(example)
      endif()
    
   -  install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
   +  install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/include/ DESTINATION 
${CMAKE_INSTALL_INCLUDEDIR})
    
    endif()
    if (INSTALL_EXAMPLES)
   -  install(DIRECTORY example  DESTINATION 
${CMAKE_INSTALL_DATADIR}/${PROJECT_NAME})
   +  install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/example  DESTINATION 
${CMAKE_INSTALL_DATADIR}/${PROJECT_NAME})
    endif()
    
    if (USE_SIGNAL_HANDLER)
   diff --git a/cpp-package/CMakeLists.txt b/cpp-package/CMakeLists.txt
   index fec86e78e6..fea58ed91a 100644
   --- a/cpp-package/CMakeLists.txt
   +++ b/cpp-package/CMakeLists.txt
   @@ -20,6 +20,6 @@ if(USE_CPP_PACKAGE)
        add_subdirectory(example)
      endif()
    
   -  install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
   +  install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/include/ DESTINATION 
${CMAKE_INSTALL_INCLUDEDIR})
    
    endif()
   (END)
   ~~~
   
   in test. but seems need added the same thing in the 3rdparties libraries

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to