zachgk commented on a change in pull request #14687: License Googletest and
Appendix
URL: https://github.com/apache/incubator-mxnet/pull/14687#discussion_r275556773
##########
File path: LICENSE
##########
@@ -706,3 +706,247 @@
FOR ANY DAMAGES OR OTHER LIABILITY, WHETHER IN CONTRACT, TORT OR OTHERWISE,
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN THE SOFTWARE.
+
+
+
+
=======================================================================================
+ Appendix
+
=======================================================================================
+
+ Apache License
Review comment:
They are there for different reasons. The one at the top is the license for
the MXNet project. The one at the bottom is part of the list of fully written
out licenses that are used by the third party projects. I thought it would be a
bit odd to have it say to find the licenses in the Appendix and then the
appendix says look at the top of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services