KellenSunderland edited a comment on issue #14591: Reference engine from chunk via weak pointer URL: https://github.com/apache/incubator-mxnet/pull/14591#issuecomment-483520820 @anirudh2290 Good point. Took me a while to think of how we can test this. Reproducing the issue is only possible when we have static de-allocating. A bit tricky to test without modifying the code to make non-static scoped. I created a test that at a minimum crashes on my machine without the fix. It'll mark the test as passed but it will crash the test process (which will prevent regressions in CI I hope). Stepping through I can see it's taking the branches you'd expect w and w/o the fix. I.e. with the fix it skips the engine delete. ``` Note: Google Test filter = Engine.stop_cleanup [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from Engine [ RUN ] Engine.stop_cleanup [ OK ] Engine.stop_cleanup (1 ms) [----------] 1 test from Engine (1 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (1 ms total) [ PASSED ] 1 test. Process finished with exit code 139 (interrupted by signal 11: SIGSEGV) ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
