reminisce commented on issue #14661: [numpy] Support zero-dim and zero-size 
tensors in MXNet
URL: https://github.com/apache/incubator-mxnet/pull/14661#issuecomment-483532182
 
 
   @anirudh2290 Thanks for the review. In practice,  `np_compat` needs to be 
set in the same thread as the one invoking shape inference functions, because 
that's where zero-dim and zero-size shapes are treated as unknown. In your 
example, the custom op's forward function invokes `mx.nd.ones` whose shape 
inference function was executed on the worker thread, and hence leads to 
failure. We are going to move all ops towards the direction of being numpy 
compatible, and that should include the custom op, where the forward/backward 
functions should always be scoped by the numpy-compatible state, and this 
problem can be resolved without asking users to use the decorator.
   
   I'm not familiar with how scala multi-threaded inference is implemented, but 
as long as the np_compat is set in the same thread as the one invoking shape 
inference functions, the result should be as expected.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to