eric-haibin-lin commented on a change in pull request #14683: Adding loss operator of a Hawkes self-exciting process URL: https://github.com/apache/incubator-mxnet/pull/14683#discussion_r275568481
########## File path: src/operator/contrib/hawkes_ll-inl.h ########## @@ -0,0 +1,479 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * Copyright (c) 2018 by Contributors + * \file hawkes_ll-inl.h + * \brief Log likelihood of a marked self-exciting Hawkes process + * \author Caner Turkmen <[email protected]> + */ +#ifndef MXNET_OPERATOR_CONTRIB_HAWKES_LL_INL_H_ +#define MXNET_OPERATOR_CONTRIB_HAWKES_LL_INL_H_ + +#include <mxnet/operator.h> +#include <vector> + +#include "../operator_common.h" +#include "../mshadow_op.h" +#include "../mxnet_op.h" + +namespace mxnet { +namespace op { + +inline bool HawkesLLOpType(const nnvm::NodeAttrs& attrs, + std::vector<int>* in_attrs, + std::vector<int>* out_attrs) { + // check dimensions of the type vectors + CHECK_EQ(in_attrs->size(), 8U); + CHECK_EQ(out_attrs->size(), 2U); + + TYPE_ASSIGN_CHECK(*out_attrs, 0, in_attrs->at(0)) // log likelihoods + TYPE_ASSIGN_CHECK(*out_attrs, 1, in_attrs->at(0)) // new states + + for (index_t j = 0; j < 8; ++j) { + if (j != 5) { Review comment: Can we have enums that indicate positional indices for these inputs, instead of integers? e.g. https://github.com/apache/incubator-mxnet/blob/master/src/operator/tensor/indexing_op.h#L56 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
