larroy commented on a change in pull request #14570: add a compiler flag to use
int64 as tensor size
URL: https://github.com/apache/incubator-mxnet/pull/14570#discussion_r276802640
##########
File path: include/mxnet/tensor_blob.h
##########
@@ -456,7 +456,7 @@ class FieldEntry<mxnet::TShape>
this->enforce_nonzero_ = true;
return this->self();
}
- inline FieldEntry<mxnet::TShape> &set_expect_ndim(mxnet::index_t ndim) {
+ inline FieldEntry<mxnet::TShape> &set_expect_ndim(int ndim) {
Review comment:
Adding to this, the type is signed ok I understand that. I still think we
should specify the width of the type, say int32_t
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
