marcoabreu commented on a change in pull request #14631: Fix
build_ccache_wrappers:
URL: https://github.com/apache/incubator-mxnet/pull/14631#discussion_r276877919
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -66,37 +66,28 @@ build_ccache_wrappers() {
# But in the beginning, we'll make this opt-in. In future, loads of
processes like
# the scala make step or numpy compilation and other pip package
generations
# could be heavily sped up by using ccache as well.
- mkdir /tmp/ccache-redirects
+ mkdir -p /tmp/ccache-redirects
export PATH=/tmp/ccache-redirects:$PATH
- ln -s ccache /tmp/ccache-redirects/gcc
- ln -s ccache /tmp/ccache-redirects/gcc-8
- ln -s ccache /tmp/ccache-redirects/g++
- ln -s ccache /tmp/ccache-redirects/g++-8
- ln -s ccache /tmp/ccache-redirects/nvcc
- ln -s ccache /tmp/ccache-redirects/clang++-3.9
- ln -s ccache /tmp/ccache-redirects/clang-3.9
- ln -s ccache /tmp/ccache-redirects/clang++-5.0
- ln -s ccache /tmp/ccache-redirects/clang-5.0
- ln -s ccache /tmp/ccache-redirects/clang++-6.0
- ln -s ccache /tmp/ccache-redirects/clang-6.0
- ln -s ccache /usr/local/bin/gcc
- ln -s ccache /usr/local/bin/gcc-8
- ln -s ccache /usr/local/bin/g++
- ln -s ccache /usr/local/bin/g++-8
- ln -s ccache /usr/local/bin/nvcc
- ln -s ccache /usr/local/bin/clang++-3.9
- ln -s ccache /usr/local/bin/clang-3.9
- ln -s ccache /usr/local/bin/clang++-5.0
- ln -s ccache /usr/local/bin/clang-5.0
- ln -s ccache /usr/local/bin/clang++-6.0
- ln -s ccache /usr/local/bin/clang-6.0
Review comment:
We spoke about this already a dozen times, so I will only link the official
guide: https://ccache.dev/manual/latest.html#_run_modes
Back when I developed this, I tested it only by relaying on the PATH and it
didn't work. Thus, I added the /usr/local/bin method.
The links did work - why shouldn't they?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
