marcoabreu edited a comment on issue #14631: Fix build_ccache_wrappers: URL: https://github.com/apache/incubator-mxnet/pull/14631#issuecomment-484739416 This code produces the following output: ``` ls -l /usr/local/bin ln -s ccache /usr/local/bin/gcc ln -s ccache /usr/local/bin/gcc-8 ln -s ccache /usr/local/bin/g++ ln -s ccache /usr/local/bin/g++-8 ln -s ccache /usr/local/bin/nvcc ln -s ccache /usr/local/bin/clang++-3.9 ln -s ccache /usr/local/bin/clang-3.9 ln -s ccache /usr/local/bin/clang++-5.0 ln -s ccache /usr/local/bin/clang-5.0 ln -s ccache /usr/local/bin/clang++-6.0 ln -s ccache /usr/local/bin/clang-6.0 ls -l /usr/local/bin ``` ``` + ls -l /usr/local/bin total 872 drwxr-xr-x 1 jenkins_slave root 4096 Apr 16 22:48 __pycache__ -rwxr-xr-x 1 jenkins_slave root 229 Apr 16 22:48 backend-test-tools -rwxr-xr-x 1 jenkins_slave root 216 Apr 16 22:49 breathe-apidoc -rwxr-xr-x 1 jenkins_slave root 497848 Apr 16 22:36 ccache -rwxr-xr-x 1 jenkins_slave root 224 Apr 16 22:37 chardetect -rwxr-xr-x 1 jenkins_slave root 232 Apr 16 22:48 check-model -rwxr-xr-x 1 jenkins_slave root 230 Apr 16 22:48 check-node -rwxr-xr-x 1 jenkins_slave root 228 Apr 16 22:49 cm2html -rwxr-xr-x 1 jenkins_slave root 230 Apr 16 22:49 cm2latex -rwxr-xr-x 1 jenkins_slave root 226 Apr 16 22:49 cm2man -rwxr-xr-x 1 jenkins_slave root 238 Apr 16 22:49 cm2pseudoxml -rwxr-xr-x 1 jenkins_slave root 230 Apr 16 22:49 cm2xetex -rwxr-xr-x 1 jenkins_slave root 226 Apr 16 22:49 cm2xml lrwxrwxrwx 1 jenkins_slave root 20 Apr 16 22:35 cmake -> /opt/cmake/bin/cmake -rwxr-xr-x 1 jenkins_slave root 1108 Apr 16 22:49 cmark.py -rw-r--r-- 1 jenkins_slave root 1462 Apr 16 22:49 cmark.pyc -rwxr-xr-x 1 jenkins_slave root 218 Apr 16 22:48 coverage -rwxr-xr-x 1 jenkins_slave root 218 Apr 16 22:48 coverage-2.7 -rwxr-xr-x 1 jenkins_slave root 218 Apr 16 22:48 coverage-3.5 -rwxr-xr-x 1 jenkins_slave root 218 Apr 16 22:48 coverage2 -rwxr-xr-x 1 jenkins_slave root 218 Apr 16 22:48 coverage3 -rwxr-xr-x 1 jenkins_slave root 209 Apr 16 22:37 cpplint -rwxr-xr-x 1 jenkins_slave root 223 Apr 16 22:46 cygdb -rwxr-xr-x 1 jenkins_slave root 244 Apr 16 22:46 cython -rwxr-xr-x 1 jenkins_slave root 224 Apr 16 22:46 cythonize -rwxr-xr-x 1 jenkins_slave root 233 Apr 16 22:36 easy_install -rwxr-xr-x 1 jenkins_slave root 233 Apr 16 22:36 easy_install-2.7 -rwxr-xr-x 1 jenkins_slave root 233 Apr 16 22:36 easy_install-3.5 -rwxr-xr-x 1 jenkins_slave root 222 Apr 16 22:49 epylint -rwxr-xr-x 1 jenkins_slave root 758 Apr 16 22:37 f2py -rw-r--r-- 1 jenkins_slave root 18864 Apr 16 22:47 gflags2man.py -rw-r--r-- 1 jenkins_slave root 18063 Apr 16 22:47 gflags2man.pyc -rwxr-xr-x 1 jenkins_slave root 234 Apr 16 22:47 iptest -rwxr-xr-x 1 jenkins_slave root 234 Apr 16 22:47 iptest2 -rwxr-xr-x 1 jenkins_slave root 227 Apr 16 22:47 ipython -rwxr-xr-x 1 jenkins_slave root 227 Apr 16 22:47 ipython2 -rwxr-xr-x 1 jenkins_slave root 212 Apr 16 22:37 isort -rwxr-xr-x 1 jenkins_slave root 1675 Apr 16 22:37 jp.py -rw-r--r-- 1 jenkins_slave root 1846 Apr 16 22:37 jp.pyc -rwxr-xr-x 1 jenkins_slave root 12538 Apr 16 22:38 lein -rwxr-xr-x 1 jenkins_slave root 214 Apr 16 22:37 nosetests -rwxr-xr-x 1 jenkins_slave root 214 Apr 16 22:36 nosetests-2.7 -rwxr-xr-x 1 jenkins_slave root 214 Apr 16 22:37 nosetests-3.4 -rwxr-xr-x 1 jenkins_slave root 214 Apr 16 22:49 pbr -rwxr-xr-x 1 jenkins_slave root 215 Apr 16 22:36 pip -rwxr-xr-x 1 jenkins_slave root 215 Apr 16 22:36 pip2 -rwxr-xr-x 1 jenkins_slave root 215 Apr 16 22:36 pip2.7 -rwxr-xr-x 1 jenkins_slave root 215 Apr 16 22:36 pip3 -rwxr-xr-x 1 jenkins_slave root 215 Apr 16 22:36 pip3.5 -rwxr-xr-x 1 jenkins_slave root 208 Apr 16 22:48 py.test -rwxr-xr-x 1 jenkins_slave root 225 Apr 16 22:49 pybabel -rwxr-xr-x 1 jenkins_slave root 218 Apr 16 22:48 pygmentize -rwxr-xr-x 1 jenkins_slave root 220 Apr 16 22:49 pylint -rwxr-xr-x 1 jenkins_slave root 226 Apr 16 22:49 pyreverse -rwxr-xr-x 1 jenkins_slave root 208 Apr 16 22:48 pytest -rwxr-xr-x 1 jenkins_slave root 594 Apr 16 22:37 rst2html.py -rw-r--r-- 1 jenkins_slave root 604 Apr 16 22:37 rst2html.pyc -rwxr-xr-x 1 jenkins_slave root 714 Apr 16 22:37 rst2html4.py -rw-r--r-- 1 jenkins_slave root 726 Apr 16 22:37 rst2html4.pyc -rwxr-xr-x 1 jenkins_slave root 1139 Apr 16 22:37 rst2html5.py -rw-r--r-- 1 jenkins_slave root 730 Apr 16 22:37 rst2html5.pyc -rwxr-xr-x 1 jenkins_slave root 791 Apr 16 22:37 rst2latex.py -rw-r--r-- 1 jenkins_slave root 734 Apr 16 22:37 rst2latex.pyc -rwxr-xr-x 1 jenkins_slave root 600 Apr 16 22:37 rst2man.py -rw-r--r-- 1 jenkins_slave root 709 Apr 16 22:37 rst2man.pyc -rwxr-xr-x 1 jenkins_slave root 764 Apr 16 22:37 rst2odt.py -rw-r--r-- 1 jenkins_slave root 803 Apr 16 22:37 rst2odt.pyc -rwxr-xr-x 1 jenkins_slave root 1698 Apr 16 22:37 rst2odt_prepstyles.py -rw-r--r-- 1 jenkins_slave root 2044 Apr 16 22:37 rst2odt_prepstyles.pyc -rwxr-xr-x 1 jenkins_slave root 601 Apr 16 22:37 rst2pseudoxml.py -rw-r--r-- 1 jenkins_slave root 600 Apr 16 22:37 rst2pseudoxml.pyc -rwxr-xr-x 1 jenkins_slave root 637 Apr 16 22:37 rst2s5.py -rw-r--r-- 1 jenkins_slave root 649 Apr 16 22:37 rst2s5.pyc -rwxr-xr-x 1 jenkins_slave root 871 Apr 16 22:37 rst2xetex.py -rw-r--r-- 1 jenkins_slave root 817 Apr 16 22:37 rst2xetex.pyc -rwxr-xr-x 1 jenkins_slave root 602 Apr 16 22:37 rst2xml.py -rw-r--r-- 1 jenkins_slave root 612 Apr 16 22:37 rst2xml.pyc -rwxr-xr-x 1 jenkins_slave root 670 Apr 16 22:37 rstpep2html.py -rw-r--r-- 1 jenkins_slave root 680 Apr 16 22:37 rstpep2html.pyc -rwxr-xr-x 1 jenkins_slave root 223 Apr 16 22:47 skivi -rwxr-xr-x 1 jenkins_slave root 215 Apr 16 22:49 sphinx-apidoc -rwxr-xr-x 1 jenkins_slave root 233 Apr 16 22:49 sphinx-autogen -rwxr-xr-x 1 jenkins_slave root 208 Apr 16 22:49 sphinx-build -rwxr-xr-x 1 jenkins_slave root 219 Apr 16 22:49 sphinx-quickstart -rwxr-xr-x 1 jenkins_slave root 222 Apr 16 22:49 symilar -rwxr-xr-x 1 jenkins_slave root 212 Apr 16 22:48 tabulate -rwxr-xr-x 1 jenkins_slave root 211 Apr 16 22:36 wheel + ln -s ccache /usr/local/bin/gcc + ln -s ccache /usr/local/bin/gcc-8 + ln -s ccache /usr/local/bin/g++ + ln -s ccache /usr/local/bin/g++-8 + ln -s ccache /usr/local/bin/nvcc + ln -s ccache /usr/local/bin/clang++-3.9 + ln -s ccache /usr/local/bin/clang-3.9 + ln -s ccache /usr/local/bin/clang++-5.0 + ln -s ccache /usr/local/bin/clang-5.0 + ln -s ccache /usr/local/bin/clang++-6.0 + ln -s ccache /usr/local/bin/clang-6.0 + ls -l /usr/local/bin total 872 drwxr-xr-x 1 jenkins_slave root 4096 Apr 16 22:48 __pycache__ -rwxr-xr-x 1 jenkins_slave root 229 Apr 16 22:48 backend-test-tools -rwxr-xr-x 1 jenkins_slave root 216 Apr 16 22:49 breathe-apidoc -rwxr-xr-x 1 jenkins_slave root 497848 Apr 16 22:36 ccache -rwxr-xr-x 1 jenkins_slave root 224 Apr 16 22:37 chardetect -rwxr-xr-x 1 jenkins_slave root 232 Apr 16 22:48 check-model -rwxr-xr-x 1 jenkins_slave root 230 Apr 16 22:48 check-node lrwxrwxrwx 1 jenkins_slave jenkins_slave 6 Apr 19 01:20 clang++-3.9 -> ccache lrwxrwxrwx 1 jenkins_slave jenkins_slave 6 Apr 19 01:20 clang++-5.0 -> ccache lrwxrwxrwx 1 jenkins_slave jenkins_slave 6 Apr 19 01:20 clang++-6.0 -> ccache lrwxrwxrwx 1 jenkins_slave jenkins_slave 6 Apr 19 01:20 clang-3.9 -> ccache lrwxrwxrwx 1 jenkins_slave jenkins_slave 6 Apr 19 01:20 clang-5.0 -> ccache lrwxrwxrwx 1 jenkins_slave jenkins_slave 6 Apr 19 01:20 clang-6.0 -> ccache -rwxr-xr-x 1 jenkins_slave root 228 Apr 16 22:49 cm2html -rwxr-xr-x 1 jenkins_slave root 230 Apr 16 22:49 cm2latex -rwxr-xr-x 1 jenkins_slave root 226 Apr 16 22:49 cm2man -rwxr-xr-x 1 jenkins_slave root 238 Apr 16 22:49 cm2pseudoxml -rwxr-xr-x 1 jenkins_slave root 230 Apr 16 22:49 cm2xetex -rwxr-xr-x 1 jenkins_slave root 226 Apr 16 22:49 cm2xml lrwxrwxrwx 1 jenkins_slave root 20 Apr 16 22:35 cmake -> /opt/cmake/bin/cmake -rwxr-xr-x 1 jenkins_slave root 1108 Apr 16 22:49 cmark.py -rw-r--r-- 1 jenkins_slave root 1462 Apr 16 22:49 cmark.pyc -rwxr-xr-x 1 jenkins_slave root 218 Apr 16 22:48 coverage -rwxr-xr-x 1 jenkins_slave root 218 Apr 16 22:48 coverage-2.7 -rwxr-xr-x 1 jenkins_slave root 218 Apr 16 22:48 coverage-3.5 -rwxr-xr-x 1 jenkins_slave root 218 Apr 16 22:48 coverage2 -rwxr-xr-x 1 jenkins_slave root 218 Apr 16 22:48 coverage3 -rwxr-xr-x 1 jenkins_slave root 209 Apr 16 22:37 cpplint -rwxr-xr-x 1 jenkins_slave root 223 Apr 16 22:46 cygdb -rwxr-xr-x 1 jenkins_slave root 244 Apr 16 22:46 cython -rwxr-xr-x 1 jenkins_slave root 224 Apr 16 22:46 cythonize -rwxr-xr-x 1 jenkins_slave root 233 Apr 16 22:36 easy_install -rwxr-xr-x 1 jenkins_slave root 233 Apr 16 22:36 easy_install-2.7 -rwxr-xr-x 1 jenkins_slave root 233 Apr 16 22:36 easy_install-3.5 -rwxr-xr-x 1 jenkins_slave root 222 Apr 16 22:49 epylint -rwxr-xr-x 1 jenkins_slave root 758 Apr 16 22:37 f2py lrwxrwxrwx 1 jenkins_slave jenkins_slave 6 Apr 19 01:20 g++ -> ccache lrwxrwxrwx 1 jenkins_slave jenkins_slave 6 Apr 19 01:20 g++-8 -> ccache lrwxrwxrwx 1 jenkins_slave jenkins_slave 6 Apr 19 01:20 gcc -> ccache lrwxrwxrwx 1 jenkins_slave jenkins_slave 6 Apr 19 01:20 gcc-8 -> ccache -rw-r--r-- 1 jenkins_slave root 18864 Apr 16 22:47 gflags2man.py -rw-r--r-- 1 jenkins_slave root 18063 Apr 16 22:47 gflags2man.pyc -rwxr-xr-x 1 jenkins_slave root 234 Apr 16 22:47 iptest -rwxr-xr-x 1 jenkins_slave root 234 Apr 16 22:47 iptest2 -rwxr-xr-x 1 jenkins_slave root 227 Apr 16 22:47 ipython -rwxr-xr-x 1 jenkins_slave root 227 Apr 16 22:47 ipython2 -rwxr-xr-x 1 jenkins_slave root 212 Apr 16 22:37 isort -rwxr-xr-x 1 jenkins_slave root 1675 Apr 16 22:37 jp.py -rw-r--r-- 1 jenkins_slave root 1846 Apr 16 22:37 jp.pyc -rwxr-xr-x 1 jenkins_slave root 12538 Apr 16 22:38 lein -rwxr-xr-x 1 jenkins_slave root 214 Apr 16 22:37 nosetests -rwxr-xr-x 1 jenkins_slave root 214 Apr 16 22:36 nosetests-2.7 -rwxr-xr-x 1 jenkins_slave root 214 Apr 16 22:37 nosetests-3.4 lrwxrwxrwx 1 jenkins_slave jenkins_slave 6 Apr 19 01:20 nvcc -> ccache -rwxr-xr-x 1 jenkins_slave root 214 Apr 16 22:49 pbr -rwxr-xr-x 1 jenkins_slave root 215 Apr 16 22:36 pip -rwxr-xr-x 1 jenkins_slave root 215 Apr 16 22:36 pip2 -rwxr-xr-x 1 jenkins_slave root 215 Apr 16 22:36 pip2.7 -rwxr-xr-x 1 jenkins_slave root 215 Apr 16 22:36 pip3 -rwxr-xr-x 1 jenkins_slave root 215 Apr 16 22:36 pip3.5 -rwxr-xr-x 1 jenkins_slave root 208 Apr 16 22:48 py.test -rwxr-xr-x 1 jenkins_slave root 225 Apr 16 22:49 pybabel -rwxr-xr-x 1 jenkins_slave root 218 Apr 16 22:48 pygmentize -rwxr-xr-x 1 jenkins_slave root 220 Apr 16 22:49 pylint -rwxr-xr-x 1 jenkins_slave root 226 Apr 16 22:49 pyreverse -rwxr-xr-x 1 jenkins_slave root 208 Apr 16 22:48 pytest -rwxr-xr-x 1 jenkins_slave root 594 Apr 16 22:37 rst2html.py -rw-r--r-- 1 jenkins_slave root 604 Apr 16 22:37 rst2html.pyc -rwxr-xr-x 1 jenkins_slave root 714 Apr 16 22:37 rst2html4.py -rw-r--r-- 1 jenkins_slave root 726 Apr 16 22:37 rst2html4.pyc -rwxr-xr-x 1 jenkins_slave root 1139 Apr 16 22:37 rst2html5.py -rw-r--r-- 1 jenkins_slave root 730 Apr 16 22:37 rst2html5.pyc -rwxr-xr-x 1 jenkins_slave root 791 Apr 16 22:37 rst2latex.py -rw-r--r-- 1 jenkins_slave root 734 Apr 16 22:37 rst2latex.pyc -rwxr-xr-x 1 jenkins_slave root 600 Apr 16 22:37 rst2man.py -rw-r--r-- 1 jenkins_slave root 709 Apr 16 22:37 rst2man.pyc -rwxr-xr-x 1 jenkins_slave root 764 Apr 16 22:37 rst2odt.py -rw-r--r-- 1 jenkins_slave root 803 Apr 16 22:37 rst2odt.pyc -rwxr-xr-x 1 jenkins_slave root 1698 Apr 16 22:37 rst2odt_prepstyles.py -rw-r--r-- 1 jenkins_slave root 2044 Apr 16 22:37 rst2odt_prepstyles.pyc -rwxr-xr-x 1 jenkins_slave root 601 Apr 16 22:37 rst2pseudoxml.py -rw-r--r-- 1 jenkins_slave root 600 Apr 16 22:37 rst2pseudoxml.pyc -rwxr-xr-x 1 jenkins_slave root 637 Apr 16 22:37 rst2s5.py -rw-r--r-- 1 jenkins_slave root 649 Apr 16 22:37 rst2s5.pyc -rwxr-xr-x 1 jenkins_slave root 871 Apr 16 22:37 rst2xetex.py -rw-r--r-- 1 jenkins_slave root 817 Apr 16 22:37 rst2xetex.pyc -rwxr-xr-x 1 jenkins_slave root 602 Apr 16 22:37 rst2xml.py -rw-r--r-- 1 jenkins_slave root 612 Apr 16 22:37 rst2xml.pyc -rwxr-xr-x 1 jenkins_slave root 670 Apr 16 22:37 rstpep2html.py -rw-r--r-- 1 jenkins_slave root 680 Apr 16 22:37 rstpep2html.pyc -rwxr-xr-x 1 jenkins_slave root 223 Apr 16 22:47 skivi -rwxr-xr-x 1 jenkins_slave root 215 Apr 16 22:49 sphinx-apidoc -rwxr-xr-x 1 jenkins_slave root 233 Apr 16 22:49 sphinx-autogen -rwxr-xr-x 1 jenkins_slave root 208 Apr 16 22:49 sphinx-build -rwxr-xr-x 1 jenkins_slave root 219 Apr 16 22:49 sphinx-quickstart -rwxr-xr-x 1 jenkins_slave root 222 Apr 16 22:49 symilar -rwxr-xr-x 1 jenkins_slave root 212 Apr 16 22:48 tabulate -rwxr-xr-x 1 jenkins_slave root 211 Apr 16 22:36 wheel ``` Thus, I can not confirm the statement that the creation of the simlinks don't work. I have made the experience that in some cases the PATH method with /usr/local/bin was not picked up. Thus, I added /usr/local/bin as suggested by CCache. When I developed this integration, I did my due diligence to compare the ccache hit rates. I don't have the cycles to dive deep into this again and stand by the stance that my developed solution is working without major issues. This modification would reduce the CCache hitrate and thus my veto stands - as I have thoroughly explained to you over the course of the last months. I have already given my review and still stand by it. Thus there are no further actions required from the reviewer side until the comments have been addressed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
