larroy commented on a change in pull request #14631: Fix build_ccache_wrappers:
URL: https://github.com/apache/incubator-mxnet/pull/14631#discussion_r276881762
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -66,37 +66,28 @@ build_ccache_wrappers() {
# But in the beginning, we'll make this opt-in. In future, loads of
processes like
# the scala make step or numpy compilation and other pip package
generations
# could be heavily sped up by using ccache as well.
- mkdir /tmp/ccache-redirects
+ mkdir -p /tmp/ccache-redirects
export PATH=/tmp/ccache-redirects:$PATH
- ln -s ccache /tmp/ccache-redirects/gcc
- ln -s ccache /tmp/ccache-redirects/gcc-8
- ln -s ccache /tmp/ccache-redirects/g++
- ln -s ccache /tmp/ccache-redirects/g++-8
- ln -s ccache /tmp/ccache-redirects/nvcc
- ln -s ccache /tmp/ccache-redirects/clang++-3.9
- ln -s ccache /tmp/ccache-redirects/clang-3.9
- ln -s ccache /tmp/ccache-redirects/clang++-5.0
- ln -s ccache /tmp/ccache-redirects/clang-5.0
- ln -s ccache /tmp/ccache-redirects/clang++-6.0
- ln -s ccache /tmp/ccache-redirects/clang-6.0
- ln -s ccache /usr/local/bin/gcc
- ln -s ccache /usr/local/bin/gcc-8
- ln -s ccache /usr/local/bin/g++
- ln -s ccache /usr/local/bin/g++-8
- ln -s ccache /usr/local/bin/nvcc
- ln -s ccache /usr/local/bin/clang++-3.9
- ln -s ccache /usr/local/bin/clang-3.9
- ln -s ccache /usr/local/bin/clang++-5.0
- ln -s ccache /usr/local/bin/clang-5.0
- ln -s ccache /usr/local/bin/clang++-6.0
- ln -s ccache /usr/local/bin/clang-6.0
Review comment:
It didn't work because your links were broken. So with my changes it works
in /tmp/ccache-redirects . there's no need to touch /usr/local/bin this is not
allowed for users, requires sudo privileges, it's not necessary, etc. Please
elaborate why you don't accept my fix, which uses the ccache wrappers in the
/tmp folder. The guide says "something like this" you are taking the guide too
seriously, having in any other folder which is then injected first in the path
is enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
