apeforest commented on a change in pull request #14095: [Don't merge] Optimize
move semantics of NodeEntry
URL: https://github.com/apache/incubator-mxnet/pull/14095#discussion_r277372637
##########
File path: dev_menu.py
##########
@@ -99,21 +99,21 @@ def create_virtualenv(venv_exe, pyexe, venv) -> None:
logging.warn("Skipping creation of virtualenv")
return
check_call([venv_exe, '-p', pyexe, venv])
- activate_this_py = os.path.join(venv, 'bin', 'activate_this.py')
- # Activate virtualenv in this interpreter
- exec(open(activate_this_py).read(), dict(__file__=activate_this_py))
- check_call(['pip', 'install', '--upgrade','--force-reinstall', '-e',
'python'])
- check_call(['pip', 'install', '-r', 'tests/requirements.txt'])
+ # TODO: Activate virtualenv in this interpreter, this is not working as it
is.
Review comment:
This change seems to be unrelated to this PR. Can we make the PR focused and
maybe create a separte PR for this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
