eric-haibin-lin commented on a change in pull request #14759: Fix softmax
behavior to not cast up the accumulator if no output dtype is specified
URL: https://github.com/apache/incubator-mxnet/pull/14759#discussion_r277378361
##########
File path: src/operator/nn/softmax-inl.h
##########
@@ -310,9 +311,9 @@ struct SoftmaxParam : public dmlc::Parameter<SoftmaxParam>
{
}
};
-static inline bool softmax_has_dtype_override(const nnvm::NodeAttrs& attrs) {
+static inline int sofmtax_dtype_param(const nnvm::NodeAttrs &attrs) {
Review comment:
typo? softmax
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
