larroy commented on issue #14631: Fix build_ccache_wrappers:
URL: https://github.com/apache/incubator-mxnet/pull/14631#issuecomment-486025182
 
 
   Thanks for your response. I don't think NVCC through ccache worked, 
otherwise why did you leave the build that this PR enables disabled?
   
   Having the ccache links in /usr/local/bin makes absolutely no difference 
versus having them in any other path is which prepended to the PATH variable. 
The result of insisting on keeping the paths in /usr/local/bin results in our 
build functions not working from a local environment to reproduce exact builds 
(since they require root) and because they are not idempotent.
   
   I can split the PR as you request. Have you seen that I verified that the 
hit rate is 100% while using the redirects in the /tmp path? Isn't this enough 
validation that the links in /usr/local/bin are not needed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to