larroy commented on a change in pull request #14779: [WIP] Fully connected,
higher order grad
URL: https://github.com/apache/incubator-mxnet/pull/14779#discussion_r277944117
##########
File path: src/operator/nn/fully_connected.cc
##########
@@ -165,6 +165,7 @@ static bool FullyConnectedType(const nnvm::NodeAttrs&
attrs,
attrs, in_type, out_type, -1);
}
+
Review comment:
I think is nice, and google style allows up to two newlines, so I don't know
why are we discussing this. If it makes you so unhappy, I remove the newline.
For me it helps readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
