eric-haibin-lin commented on a change in pull request #14782: Fix GELU backward
possible NaN
URL: https://github.com/apache/incubator-mxnet/pull/14782#discussion_r277952591
##########
File path: src/operator/mshadow_op.h
##########
@@ -45,14 +45,10 @@ namespace mshadow_op {
__constant__ const float PI = 3.14159265358979323846;
__constant__ const float SELU_ALPHA = 1.6732632423543772848170429916717;
__constant__ const float SELU_LAMBDA = 1.0507009873554804934193349852946;
-__constant__ const float GELU_CUBIC_CONSTANT = 0.044715;
Review comment:
Can we define `__constant__ const float SQRT_2 = 1.4142135623730950488;` and
avoid computing `math:sqrt(2)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
