eric-haibin-lin commented on a change in pull request #14568: NAG Optimizer
with multi-precision support
URL: https://github.com/apache/incubator-mxnet/pull/14568#discussion_r279100552
##########
File path: tests/python/unittest/test_optimizer.py
##########
@@ -417,23 +417,15 @@ def test_nag():
rg_options = [{}, {'rescale_grad': 0.14}, {'rescale_grad': 0.8}]
wd_options = [{}, {'wd': 0.03}, {'wd': 0.05}, {'wd': 0.07}]
mp_options = [{}, {'multi_precision': False}, {'multi_precision': True}]
+
for dtype in [np.float16, np.float32, np.float64]:
- for mom_option in mom_options:
- for cg_option in cg_options:
- for rg_option in rg_options:
- for wd_option in wd_options:
- for mp_option in mp_options:
- kwarg = {}
- kwarg.update(mom_option)
- kwarg.update(cg_option)
- kwarg.update(rg_option)
- kwarg.update(wd_option)
- kwarg.update(mp_option)
- if (dtype == np.float16 and
- ('multi_precision' not in kwarg or
+ for params in itertools.product(mom_options, cg_options, rg_options,
Review comment:
itertools is great
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
