junrushao1994 commented on a change in pull request #14733: Enable zero-copy
from numpy to MXNet NDArray
URL: https://github.com/apache/incubator-mxnet/pull/14733#discussion_r279128921
##########
File path: src/ndarray/ndarray.cc
##########
@@ -365,6 +365,18 @@ NDArray NDArray::FromDLPack(const DLManagedTensor*
tensor) {
return NDArray(TBlob(dl_tensor), dl_tensor.ctx.device_id, deleter);
}
+NDArray NDArray::FromDLManagedTensor(const DLManagedTensor* tensor) {
Review comment:
No. The `FromDLManagerTensor ` does not require the address `tensor` points
to to be alive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services