Chouffe commented on issue #14813: [Clojure] Remove unneeded test files URL: https://github.com/apache/incubator-mxnet/pull/14813#issuecomment-487273785 Also, not sure how to deal with @kedarbellare great feedback ``` 1. DRY the code a bit (to share as much as possible between symbol/ndarray api and random api) 2. call the scala SymbolRandomAPI and NDArrayRandomAPI 3. unify the random_ and sample_ methods (and remove them from the ndarray/symbol api namespaces) 4. add unit tests ``` ``` 1. Done 2. I could not get this to work when calling directly the `NDArrayRandomAPI` and the `SymbolRandomAPI` 3. This is not done yet. I am not entirely sure how to do that. Can it be done in a subsequent PR? 4. Done ``` Should we open issues for the things that were not done yet an tackle them in a subsequent PR? @gigasquid and @kedarbellare?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
