rondogency opened a new pull request #14840: Make docblocks for Gluon BatchNorm and SyncBatchNorm consistent with the code URL: https://github.com/apache/incubator-mxnet/pull/14840 ## Description ## Regarding issue #12681 we should use running_mean and running_var instead of moving_mean and moving_var consistently in Gluon to avoid user confusion. Although we should use moving_xxx for BatchNorm, the current code is still using running_xxx and we should not break our old Gluon API in minor release. I have put this into MXNet 2.0 roadmap https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-487217996, and we will make a complete fix down the line. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [x] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [ ] Feature1, tests, (and when applicable, API doc) - [ ] Feature2, tests, (and when applicable, API doc) ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
