anirudh2290 commented on a change in pull request #14830: [WIP] Use env var to
enforce safe accumulation in ReduceAxesCompute
URL: https://github.com/apache/incubator-mxnet/pull/14830#discussion_r279777773
##########
File path: src/operator/tensor/broadcast_reduce_op.h
##########
@@ -1183,12 +1183,23 @@ void LpNormCompute(const nnvm::NodeAttrs& attrs,
} else {
small = ReduceAxesShapeImpl(inputs[0].shape_, param.axis, true, false);
}
+
if (param.ord == 1) {
- ReduceAxesComputeImpl<xpu, mshadow_op::sum, true, false, mshadow_op::abs>(
+ if (dmlc::GetEnv("MXNET_ENFORCE_SAFE_ACCUMULATION", false)) {
+ ReduceAxesComputeImpl<xpu, mshadow_op::sum, true, false,
mshadow_op::abs>(
+ ctx, inputs, req, outputs, small);
+ } else {
+ ReduceAxesComputeImpl<xpu, mshadow_op::sum, false, false,
mshadow_op::abs>(
ctx, inputs, req, outputs, small);
+ }
} else if (param.ord == 2) {
- ReduceAxesComputeImpl<xpu, mshadow_op::nrm2, true, false,
mshadow_op::identity>(
+ if (dmlc::GetEnv("MXNET_ENFORCE_SAFE_ACCUMULATION", false)) {
Review comment:
Lets check if out_dtype is set and accordingly use safe accumulation as
discussed in: https://github.com/apache/incubator-mxnet/issues/14760 . It would
be better to not add another env variable, users can opt in by explicitly
specifying out_dtype.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
