marcoabreu commented on a change in pull request #14807: Upgrade Pylint version to 2.3.1 URL: https://github.com/apache/incubator-mxnet/pull/14807#discussion_r279998181
########## File path: python/mxnet/gluon/trainer.py ########## @@ -16,7 +16,7 @@ # under the License. # coding: utf-8 -# pylint: disable=line-too-long +# pylint: disable=line-too-long, no-else-raise Review comment: +1 Instead of adding the surpressions, I'd prefer if the points are actually being addressed - or a specific disable if there's really no sense in implementing the suggestion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
