stu1130 commented on a change in pull request #14807: Upgrade Pylint version to 2.3.1 URL: https://github.com/apache/incubator-mxnet/pull/14807#discussion_r280000844
########## File path: python/mxnet/gluon/trainer.py ########## @@ -16,7 +16,7 @@ # under the License. # coding: utf-8 -# pylint: disable=line-too-long +# pylint: disable=line-too-long, no-else-raise Review comment: Since it's related to Numpy version update due to [security vulnerability issue](https://nvd.nist.gov/vuln/detail/CVE-2019-6446#vulnCurrentDescriptionTitle), I would prefer to use the issue #14851 to track and fix it later. Personally, I would prefer to suppress unnecessary-pass & no-else-raise for better readability. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
