lebeg commented on a change in pull request #14829: Fix the incorrect MKLDNN/MKL logic in cmake URL: https://github.com/apache/incubator-mxnet/pull/14829#discussion_r280369265
########## File path: cmake/Modules/FindMKL.cmake ########## @@ -43,55 +43,7 @@ endif() # ---[ Root folders set(INTEL_ROOT "/opt/intel" CACHE PATH "Folder contains intel libs") -if(USE_MKLDNN) Review comment: Though now it is convoluted in 1 file there is a configuration difference between full MKL and MKLML. For example, the `librt` library is present only in full MKL, OpenMP library needs to be configured explicitly for MKLML. Previously, I made an attempt to separate it to 2 different files, maybe you can reuse some code from there [#11148](https://github.com/apache/incubator-mxnet/pull/11148/files) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
