roywei commented on a change in pull request #14629: [MXNET-1333] Estimator and
Fit API
URL: https://github.com/apache/incubator-mxnet/pull/14629#discussion_r280603554
##########
File path: python/mxnet/gluon/trainer.py
##########
@@ -255,6 +255,13 @@ def learning_rate(self):
else:
return self._optimizer.learning_rate
+ @property
+ def optimizer(self):
Review comment:
I m exposing optimizer through trainer, as estimator only has access to
trainer. For now it's only used for logging and type and name. Let me know if I
should remove this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
