roywei opened a new pull request #14869: [WIP][Do Not Merge]Fix infer shape partial after unknown shape changed to -1 URL: https://github.com/apache/incubator-mxnet/pull/14869 ## Description ## partially fix https://github.com/apache/incubator-mxnet/issues/14833 for now As we changed unknown shape in mxnet from 0 to -1, some operators infer shape logic could be wrong. MXNet unit tests are not testing for this corner case, but Keras-MXNet relies heavily on parietal shape infer, so many unit tests are failing. 1. changed `CHECK_GE` and `CHECK_LE` to compare `ndim()` with signed int as LHS could be -1 now. 2. When a tensor shape is entirely unknown, we should return directly. But we need to use `ndim_is_known` instead of `shape_is_known`. Because we can still continue to infer shape if tensor shape if partially unknown. Using `shape_is_known` will cause a direct return unless the tensor shape is fully known. 3. For binary ops, if LHS and RHS both have fully unknown shapes, we should return directly. `dot` ops is missing this logic. 4. added unit tests This fixes most failing keras-mxnet unit tests. I will need to go through all other operators failing and adding unit tests where applicable. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes) - [ ] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [ ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [ ] Feature1, tests, (and when applicable, API doc) - [ ] Feature2, tests, (and when applicable, API doc) ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
