szha commented on a change in pull request #14899: Add mkldnn_version.h to pip
package
URL: https://github.com/apache/incubator-mxnet/pull/14899#discussion_r281353975
##########
File path: tools/pip/setup.py
##########
@@ -152,6 +152,8 @@ def has_ext_modules(self):
package_data['mxnet'].append('mxnet/libmkldnn.so.0')
shutil.copytree(os.path.join(CURRENT_DIR,
'mxnet-build/3rdparty/mkldnn/include'),
Review comment:
I thought the whole mkldnn include folder should already have been included
here. Should we just change this to copy from the build folder instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
