eric-haibin-lin commented on a change in pull request #14885: [Fit-API] Adress 
PR comments
URL: https://github.com/apache/incubator-mxnet/pull/14885#discussion_r282139233
 
 

 ##########
 File path: python/mxnet/gluon/contrib/estimator/estimator.py
 ##########
 @@ -190,26 +195,29 @@ def prepare_loss_and_metrics(self):
 
     def evaluate(self,
                  val_data,
-                 val_metrics):
+                 val_metrics,
+                 batch_axis=0):
         """Evaluate model on validation data
 
          Parameters
          ----------
          val_data : DataLoader
-             validation data with data and labels
+             validation data loader with data and labels
+         batch_axis : int, default 0
 
 Review comment:
   Better to reorder the doc so that batch_axis appears last? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to