zheng-da commented on a change in pull request #14393: [MXNET-1352] Allow
dynamic shape in while_loop and if conditionals
URL: https://github.com/apache/incubator-mxnet/pull/14393#discussion_r282183009
##########
File path: include/mxnet/ndarray.h
##########
@@ -180,7 +180,9 @@ class NDArray {
* \brief set the correct shape of NDArray directly from the storage_shape
of its own chunk.
*/
void SetShapeFromChunk() {
- shape_ = ptr_->storage_shape;
+ if (!(ptr_->storage_shape.ndim() == 1 && ptr_->storage_shape[0] == 0)) {
Review comment:
why checking this case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
