TaoLv commented on a change in pull request #14893: Integrating the MKL VML functions to MXNET to speed-up the (element-wised) mathematic computation URL: https://github.com/apache/incubator-mxnet/pull/14893#discussion_r283622236
########## File path: src/operator/mkl_functions-inl.h ########## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * Copyright (c) 2018 by Contributors + * \file mkl_functions-inl.h + * \brief + * \author +*/ +#ifndef MXNET_OPERATOR_MKL_FUNCTIONS_INL_H_ +#define MXNET_OPERATOR_MKL_FUNCTIONS_INL_H_ + +#if MSHADOW_USE_MKL == 1 +#include "mkl.h" + +namespace mxnet { +namespace op { +namespace mkl_func { + +MSHADOW_XINLINE +static bool check_size(const size_t n) { Review comment: This is used to check if the size of given tensor is less then INT_MAX. This is useful especially mxnet support large tensor now (tensor size is defined with int64). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
