TaoLv commented on a change in pull request #14947: Silence excessive mkldnn
logging output on tests.
URL: https://github.com/apache/incubator-mxnet/pull/14947#discussion_r284126429
##########
File path: src/operator/nn/mkldnn/mkldnn_base.cc
##########
@@ -553,8 +553,9 @@ void OpCheck::Run(mxnet::FCompute fn, const
nnvm::NodeAttrs &attrs,
for (size_t i = 0; i < out_blobs.size(); i++)
out_blobs[i] = outputs[i].data();
fn(attrs, ctx, in_blobs, req, out_blobs);
-
+#ifndef NDEBUG
Review comment:
Thank you for fixing this. How about changing to check the environmental
variable `MXNET_MKLDNN_DEBUG`? We used this variable in other places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
