marcoabreu commented on a change in pull request #14877: Fix the incorrect
MKLDNN/MKL logic in cmake
URL: https://github.com/apache/incubator-mxnet/pull/14877#discussion_r284216027
##########
File path: ci/jenkins/Jenkins_steps.groovy
##########
@@ -515,6 +515,51 @@ def compile_windows_cpu() {
}]
}
+def compile_windows_cpu_mkldnn() {
+ return ['Build CPU MKLDNN windows':{
+ node(NODE_WINDOWS_CPU) {
+ ws('workspace/build-cpu-mkldnn') {
+ timeout(time: max_time, unit: 'MINUTES') {
+ utils.init_git_win()
+ powershell 'py -3 ci/build_windows.py -f WIN_CPU_MKLDNN'
+ stash includes: 'windows_package.7z', name:
'windows_package_cpu_mkldnn'
+ }
+ }
+ }
+ }]
+}
+
+def compile_windows_cpu_mkldnn_mkl() {
+ return ['Build CPU MKLDNN MKL windows':{
+ node(NODE_WINDOWS_CPU) {
+ ws('workspace/build-cpu-mkldnn-mkl') {
+ timeout(time: max_time, unit: 'MINUTES') {
+ utils.init_git_win()
+ //powershell '($Env:MKL_ROOT="C:\Program Files
(x86)\IntelSWTools\compilers_and_libraries\windows\mkl") -and (py -3
ci/build_windows.py -f WIN_CPU_MKLDNN_MKL)'
+ powershell 'py -3 ci/build_windows.py -f WIN_CPU_MKLDNN_MKL'
+ stash includes: 'windows_package.7z', name:
'windows_package_cpu_mkldnn_mkl'
+ }
+ }
+ }
+ }]
+}
+
+def compile_windows_cpu_mkl() {
+ return ['Build CPU MKL windows':{
+ node(NODE_WINDOWS_CPU) {
+ ws('workspace/build-cpu-mkl') {
+ timeout(time: max_time, unit: 'MINUTES') {
+ utils.init_git_win()
+ powershell '$Env:MKL_ROOT="C:\Program Files
(x86)\IntelSWTools\compilers_and_libraries\windows\mkl"'
Review comment:
Could you move this code into build_windows.py? We prefer to have these
scripts self-contained and the Jenkinsfile just being an orchestration tool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services