DickJC123 commented on issue #14954: broadcast_to() behavior change after new 0D and uninitialized shape support added? URL: https://github.com/apache/incubator-mxnet/issues/14954#issuecomment-492747233 Thank you for fixing this! Some additional suggestions: - If you allow both 0 and -1 for the output dimension 'wildcard', you probably should update the documentation to reflect this. Going forward, would you suggest people to use -1 in the shape, with the use of 0 being deprecated? - As you noticed, there's no unit test for this case. It was a number of the Sockeye unit tests that flushed out the issue for me. Even after I apply a trial fix to this problem, I still see errors in the Sockeye tests. I will be investigating these further, but you may want to try your fix against the Sockeye test suite as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
