yuxihu commented on a change in pull request #14911: Use std::exception as the
param in engine complete callback
URL: https://github.com/apache/incubator-mxnet/pull/14911#discussion_r284789504
##########
File path: include/mxnet/engine.h
##########
@@ -74,15 +74,15 @@ class CallbackOnComplete {
public:
// use implicit copy and assign
/*! \brief involve the callback */
- inline void operator()(const dmlc::Error* error = nullptr) const {
+ inline void operator()(const std::exception* error = nullptr) const {
Review comment:
I changed [this
place](https://github.com/apache/incubator-mxnet/pull/14911/commits/ee563d0edaf12e0d62112680e8a0bbb1a18501e4#diff-a3398a203d3c98a27e506bf3215afa18R385)
to use this new interface. A lot existing negative test cases have already
covered it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
